Update yamllint to fix dependency issue

I think this still validates everything we need it to

ansible/.ansible-lint

@@ -1,10 +1,11 @@
 skip_list:
-  - 305
-  - 401
-  - 301
-  - 503
+  - command-instead-of-shell
+  - no-handler
+  - git-latest
 
 exclude_paths:
   - ansible/galaxy_roles/
   - ansible/galaxy_collections/
   - ~/.ansible
+  - roles/nebula/files/nebula.yml
+  - roles/traefik/files/traefik.yml

ansible/dev-requirements.txt

@@ -1,2 +1,2 @@
-ansible-lint==4.3.5
+ansible-lint==5.3.2
 yamllint==1.24.2

ansible/group_vars/all/base.yml

@@ -1,4 +1,4 @@
-TZ: Europe/London
+timezone: Europe/London  # noqa var-naming
 
 # HACK: Some of the hostnames aren't valid dict keys
 hostname_slug: "{{ ansible_hostname | replace('-', '_') }}"

ansible/main.yml

@@ -22,7 +22,7 @@
     - role: geerlingguy.ntp
       become: true
       vars:
-        ntp_timezone: "{{ TZ }}"
+        ntp_timezone: "{{ timezone }}"
         ntp_manage_config: true
 
 - hosts:

ansible/roles/base/tasks/ssh.yml

@@ -20,7 +20,7 @@
     src: files/sshd_config
     dest: /etc/ssh/sshd_config
     validate: /usr/sbin/sshd -t -f %s
-    backup: yes
+    backup: true
     mode: 0644
   become: true
   register: sshd_config

ansible/roles/forrest/files/grafana/docker-compose.yml

@@ -4,7 +4,7 @@ services:
   grafana:
     image: grafana/grafana:latest
     environment:
-      - TZ={{ TZ }}
+      - TZ={{ timezone }}
       - GF_DATABASE_URL=postgres://grafana:grafana@db/grafana
       - GF_RENDERING_SERVER_URL=http://renderer:8081/render
       - GF_RENDERING_CALLBACK_URL=http://grafana:3000/
@@ -42,7 +42,7 @@ services:
     image: grafana/grafana-image-renderer:latest
     restart: unless-stopped
     environment:
-      - BROWSER_TZ={{ TZ }}
+      - BROWSER_TZ={{ timezone }}
 
 
 networks:

ansible/roles/gateway/tasks/wireguard.yml

@@ -3,7 +3,7 @@
     src: files/wireguard-server.conf
     dest: /etc/wireguard/wg0.conf
     mode: "0600"
-    backup: yes
+    backup: true
   become: true
   register: wireguard_conf
 
@@ -41,9 +41,9 @@
   sysctl:
     name: net.ipv4.ip_forward
     value: "1"
-    sysctl_set: yes
+    sysctl_set: true
     state: present
-    reload: yes
+    reload: true
     sysctl_file: /etc/sysctl.d/99-sysctl.conf
   become: true
 

ansible/roles/gitlab/files/gitlab.rb

@@ -11,7 +11,7 @@ nginx['ssl_certificate'] = "/etc/ssl/certs/ssl-cert-snakeoil.pem"
 nginx['ssl_certificate_key'] = "/etc/ssl/private/ssl-cert-snakeoil.key"
 letsencrypt['enable'] = false
 
-gitlab_rails['time_zone'] = '{{ TZ }}'
+gitlab_rails['time_zone'] = '{{ timezone }}'
 
 # https://docs.gitlab.com/omnibus/settings/memory_constrained_envs.html
 puma['worker_processes'] = 2

ansible/roles/ingress/tasks/wireguard.yml

@@ -27,8 +27,8 @@
   sysctl:
     name: net.ipv4.ip_forward
     value: "1"
-    sysctl_set: yes
+    sysctl_set: true
     state: present
-    reload: yes
+    reload: true
     sysctl_file: /etc/sysctl.d/99-sysctl.conf
   become: true

ansible/roles/nebula/tasks/main.yml

@@ -9,7 +9,7 @@
   unarchive:
     src: https://github.com/slackhq/nebula/releases/download/v{{ nebula_version }}/nebula-linux-amd64.tar.gz
     dest: /usr/bin
-    remote_src: yes
+    remote_src: true
     mode: "0755"
   become: true
   notify: restart nebula

ansible/roles/privatebin/files/docker-compose.yml

@@ -4,7 +4,7 @@ services:
   privatebin:
     image: privatebin/nginx-fpm-alpine:latest
     environment:
-      - TZ={{ TZ }}
+      - TZ={{ timezone }}
     volumes:
       - "{{ app_data_dir }}/privatebin/:/srv/data"
       - "{{ app_data_dir }}/privatebin/conf.php:/srv/cfg/conf.php:ro"

ansible/roles/pve_docker/files/calibre/docker-compose.yml

@@ -5,7 +5,7 @@ services:
     environment:
       - PUID={{ docker_user.id }}
       - PGID={{ docker_user.id }}
-      - TZ={{ TZ }}
+      - TZ={{ timezone }}
     restart: unless-stopped
     volumes:
       - /mnt/tank/app-data/calibre:/config

ansible/roles/pve_docker/files/librespeed/docker-compose.yml

@@ -5,7 +5,7 @@ services:
     environment:
       - PUID={{ docker_user.id }}
       - PGID={{ docker_user.id }}
-      - TZ={{ TZ }}
+      - TZ={{ timezone }}
     ports:
       - 33377:80
     restart: unless-stopped

ansible/roles/pve_docker/files/nextcloud/docker-compose.yml

@@ -6,7 +6,7 @@ services:
     environment:
       - PUID={{ docker_user.id }}
       - PGID={{ docker_user.id }}
-      - TZ={{ TZ }}
+      - TZ={{ timezone }}
       - DOCKER_MODS=theorangeone/lsio-mod-more-processes:latest
     volumes:
       - "{{ app_data_dir }}/nextcloud/apps:/config/www/nextcloud/apps"

ansible/roles/pve_docker/files/quassel/docker-compose.yml

@@ -5,7 +5,7 @@ services:
     environment:
       - PUID={{ docker_user.id }}
       - PGID={{ docker_user.id }}
-      - TZ={{ TZ }}
+      - TZ={{ timezone }}
       - DB_BACKEND=PostgreSQL
       - DB_PGSQL_USERNAME=quassel
       - DB_PGSQL_PASSWORD=quassel

ansible/roles/pve_docker/files/tt-rss/docker-compose.yml

@@ -6,7 +6,7 @@ services:
     environment:
       - PUID={{ docker_user.id }}
       - PGID={{ docker_user.id }}
-      - TZ={{ TZ }}
+      - TZ={{ timezone }}
       - DOCKER_MODS=theorangeone/lsio-mod-more-processes:latest
 
       - TTRSS_DB_USER=tt-rss

ansible/roles/renovate/files/docker-compose.yml

@@ -5,7 +5,7 @@ services:
     command: /entrypoint.sh
     user: "{{ docker_user.id }}"
     environment:
-      - TZ={{ TZ }}
+      - TZ={{ timezone }}
       - GITHUB_COM_TOKEN={{ renovate_github_token }}
       - DOCKER_HOST=tcp://docker_proxy:2375
       - LOG_LEVEL=debug  # Noisy, but required for debugging

ansible/roles/uptime_kuma/files/docker-compose.yml

@@ -7,7 +7,7 @@ services:
     environment:
       - PUID={{ docker_user.id }}
       - PGID={{ docker_user.id }}
-      - TZ={{ TZ }}
+      - TZ={{ timezone }}
     volumes:
       - ./data:/app/data
     labels:

scripts/ansible/lint.sh

@@ -4,10 +4,10 @@ set -e
 
 PATH=${PWD}/env/bin:${PATH}
 
-set -x
+yamllint -sc ansible/yamllint.yml ansible
 
-yamllint -sc ansible/yamllint.yml ansible/
+cd ansible/
 
-ansible-lint ansible/main.yml -p -c ansible/.ansible-lint
+ansible-lint -p
 
-cd ansible/ && ansible-playbook main.yml --syntax-check
+ansible-playbook main.yml --syntax-check