From e39272e5b7edbbb27018155b9bcd859934f51b6b Mon Sep 17 00:00:00 2001
From: Jake Howard <git@theorangeone.net>
Date: Thu, 14 May 2020 16:43:20 +0100
Subject: [PATCH] Fix linting issues

---
 tasks/keepassxc.yml | 35 +++++++++++++++++------------------
 1 file changed, 17 insertions(+), 18 deletions(-)

diff --git a/tasks/keepassxc.yml b/tasks/keepassxc.yml
index 1496e38..e839ff9 100644
--- a/tasks/keepassxc.yml
+++ b/tasks/keepassxc.yml
@@ -1,32 +1,19 @@
-- file:
+- name: Create private directory
+  file:
     state: directory
     recurse: true
     path: "{{ home }}/Private"
     owner: "{{ user }}"
     mode: 0700
 
-- file:
+- name: Create KeepassXC config directory
+  file:
     state: directory
     recurse: true
     path: "{{ home }}/.config/keepassxc"
     owner: "{{ user }}"
     mode: 0700
 
-- set_fact:
-    keepassxc_config:
-      - {section: General, option: "SSHAgent", value: "true"}
-      - {section: General, option: "AutoSaveAfterEveryChange", value: "true"}
-      - {section: General, option: "LastOpenedDatabases", value: "{{ home }}/Private/KeePass/Password Safe.kdbx"}
-      - {section: General, option: "SingleInstance", value: "true"}
-      - {section: Http, option: "Enabled", value: "false"}
-      - {section: GUI, option: "ShowTrayIcon", value: "true"}
-      - {section: GUI, option: "MinimizeToTray", value: "true"}
-      - {section: GUI, option: "MinimizeOnStartup", value: "true"}
-      - {section: security, option: "lockdatabasescreenlock", value: "true"}
-      - {section: Browser, option: "Enabled", value: "true"}
-      - {section: Browser, option: "AlwaysAllowAccess", value: "true"}
-      - {section: Browser, option: "AlwaysAllowUpdate", value: "true"}
-
 - name: Set KeepassXC configuration
   ini_file:
     path: "{{ home }}/.config/keepassxc/keepassxc.ini"
@@ -35,6 +22,18 @@
     section: "{{ item.section }}"
     option: "{{ item.option }}"
     value: "{{ item.value }}"
-  loop: "{{ keepassxc_config }}"
   loop_control:
     label: "{{ item.section }}.{{ item.option }}={{ item.value }}"
+  loop:
+    - {section: General, option: SSHAgent, value: "true"}
+    - {section: General, option: AutoSaveAfterEveryChange, value: "true"}
+    - {section: General, option: LastOpenedDatabases, value: "{{ home }}/Private/KeePass/Password Safe.kdbx"}
+    - {section: General, option: SingleInstance, value: "true"}
+    - {section: Http, option: Enabled, value: "false"}
+    - {section: GUI, option: ShowTrayIcon, value: "true"}
+    - {section: GUI, option: MinimizeToTray, value: "true"}
+    - {section: GUI, option: MinimizeOnStartup, value: "true"}
+    - {section: security, option: lockdatabasescreenlock, value: "true"}
+    - {section: Browser, option: Enabled, value: "true"}
+    - {section: Browser, option: AlwaysAllowAccess, value: "true"}
+    - {section: Browser, option: AlwaysAllowUpdate, value: "true"}