repos/website
1
Fork 0
Code Issues 1 Pull requests 27 Activity

Only show listing images if there are some

Browse source 
This saves a bit more space for page listings which don't have images
This commit is contained in:
Jake Howard 2024-03-01 17:34:26 +00:00
parent bd4c1a193a
commit b0f1191d8f
Signed by: jake
GPG key ID: 57AFB45680EDD477
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
website/common/models.py
View file

@ -263,7 +263,12 @@ class BaseListingPage(RoutablePageMixin, BaseContentPage):
def get_context(self, request: HttpRequest) -> dict: def get_context(self, request: HttpRequest) -> dict:
context = super().get_context(request) context = super().get_context(request)
context["listing_pages"] = self.get_paginator_page() listing_pages = self.get_paginator_page()
context["listing_pages"] = listing_pages
# Show listing images if at least 1 page has an image
context["show_listing_images"] = any(p.list_image_url for p in listing_pages)
return context return context
@cached_property @cached_property

4
website/common/templates/common/listing-item.html
View file

@ -1,9 +1,9 @@
{% load wagtailcore_tags wagtail_cache util_tags %} {% load wagtailcore_tags wagtail_cache util_tags %}
{% wagtailpagecache FRAGMENT_CACHE_TTL "listing-item" breadcrumbs %} {% wagtailpagecache FRAGMENT_CACHE_TTL "listing-item" breadcrumbs show_listing_images %}
<article class="media listing-item"> <article class="media listing-item">
<div class="columns"> <div class="columns">
<figure class="media-left column is-3 image-column"> <figure class="media-left column is-{{ show_listing_images|yesno:'3,1' }} image-column">
{% if page.list_image_url %} {% if page.list_image_url %}
<a href="{% pageurl page %}" class="image" title="{{ page.title }}"> <a href="{% pageurl page %}" class="image" title="{{ page.title }}">
<img src="{{ page.list_image_url }}" alt="{{ page.hero_image_alt }}" loading="lazy" decoding="async" referrerpolicy="no-referrer" /> <img src="{{ page.list_image_url }}" alt="{{ page.hero_image_alt }}" loading="lazy" decoding="async" referrerpolicy="no-referrer" />