repos/website
1
Fork 0
Code Issues 1 Pull requests 23 Activity

Fix typing issues

Browse source
This commit is contained in:
Jake Howard 2023-11-29 14:35:07 +00:00
parent 34dcf63a93
commit 981d0ada4d
Signed by: jake
GPG key ID: 57AFB45680EDD477
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
website/common/feed_generators.py
View file

@ -1,4 +1,8 @@
from typing import Any
from django.http import HttpRequest
from django.utils.feedgenerator import DefaultFeed from django.utils.feedgenerator import DefaultFeed
from django.utils.xmlutils import SimplerXMLGenerator
class CustomFeed(DefaultFeed): class CustomFeed(DefaultFeed):
@ -6,11 +10,11 @@ class CustomFeed(DefaultFeed):
A custom feed generator with additional features. A custom feed generator with additional features.
""" """
def __init__(self, request, **kwargs): def __init__(self, request: HttpRequest, **kwargs: Any) -> None:
super().__init__(**kwargs) super().__init__(**kwargs)
self.request = request self.request = request
def add_root_elements(self, handler) -> None: def add_root_elements(self, handler: SimplerXMLGenerator) -> None:
super().add_root_elements(handler) super().add_root_elements(handler)
handler.startElement("image", {}) handler.startElement("image", {})
handler.addQuickElement("url", self.request.build_absolute_uri("favicon.ico")) handler.addQuickElement("url", self.request.build_absolute_uri("favicon.ico"))

5
website/common/views.py
View file

@ -89,7 +89,7 @@ class AllPagesFeed(Feed):
return response return response
def feed_extra_kwargs(self, obj): def feed_extra_kwargs(self, obj: None) -> dict:
return {**super().feed_extra_kwargs(obj), "request": self.request} return {**super().feed_extra_kwargs(obj), "request": self.request}
def title(self) -> str: def title(self) -> str:
@ -124,9 +124,10 @@ class AllPagesFeed(Feed):
def item_description(self, item: BasePage) -> str: def item_description(self, item: BasePage) -> str:
return getattr(item, "summary", None) or item.title return getattr(item, "summary", None) or item.title
def item_categories(self, item: BasePage): def item_categories(self, item: BasePage) -> Optional[list[str]]:
if tags := getattr(item, "tags", None): if tags := getattr(item, "tags", None):
return tags.order_by("slug").values_list("slug", flat=True) return tags.order_by("slug").values_list("slug", flat=True)
return None
def item_enclosure_url(self, item: BasePage) -> Optional[str]: def item_enclosure_url(self, item: BasePage) -> Optional[str]:
if not hasattr(item, "get_meta_image_url"): if not hasattr(item, "get_meta_image_url"):