From 735ab73ec0e189dd443ae9c899fe708ba13c4360 Mon Sep 17 00:00:00 2001 From: Jake Howard Date: Sun, 28 Aug 2022 12:59:09 +0100 Subject: [PATCH] Inline `select_related` calls --- website/blog/models.py | 6 ++---- website/common/models.py | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/website/blog/models.py b/website/blog/models.py index 663b2dd..921e697 100644 --- a/website/blog/models.py +++ b/website/blog/models.py @@ -40,8 +40,7 @@ class BlogPostListPage(BaseListingPage): return ( BlogPostPage.objects.descendant_of(self) .live() - .select_related("hero_image") - .select_related("hero_unsplash_photo") + .select_related("hero_image", "hero_unsplash_photo") .prefetch_related("tags") .order_by("-date", "title") ) @@ -120,8 +119,7 @@ class BlogPostCollectionPage(BaseListingPage): def get_listing_pages(self) -> models.QuerySet: return ( BlogPostPage.objects.child_of(self) - .select_related("hero_image") - .select_related("hero_unsplash_photo") + .select_related("hero_image", "hero_unsplash_photo") .prefetch_related("tags") .order_by("-date", "title") ) diff --git a/website/common/models.py b/website/common/models.py index cd3561b..f645e9a 100644 --- a/website/common/models.py +++ b/website/common/models.py @@ -200,8 +200,7 @@ class BaseListingPage(RoutablePageMixin, BaseContentPage): self.get_children() .live() .specific() - .select_related("hero_image") - .select_related("hero_unsplash_photo") + .select_related("hero_image", "hero_unsplash_photo") .order_by("title") )